Add psr/log ^2.0 and ^3.0 #5883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
We should also allow v3 here :) |
aschempp
approved these changes
Mar 18, 2023
Toflar
approved these changes
Mar 18, 2023
bytehead
approved these changes
Mar 19, 2023
|
Thank you @JanoschOltmanns. |
|
Thanks for approving and merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
psr/logdependency is set to^1.0A package I want to use has it set to^2.0. Unfortunately, this causes conflicts. Therefore, I propose to allow^2.0here as well. The signatures look identical, the basic tests ran through and the standard should also have no changes.Or are there any reasons for
^1.0that I don't see? (I have also proposed this change in theterminal42/escargotdependency, see terminal42/escargot#32)see #5882