Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also make response private if an Authorization header is present #594

Merged
merged 1 commit into from Jul 18, 2019

Conversation

@Toflar
Copy link
Member

commented Jul 17, 2019

No description provided.

@Toflar Toflar self-assigned this Jul 17, 2019

@Toflar Toflar added the defect label Jul 17, 2019

@Toflar Toflar added this to the 4.8 milestone Jul 17, 2019

@Toflar Toflar requested a review from ausi Jul 17, 2019

@ausi
ausi approved these changes Jul 17, 2019
@aschempp
Copy link
Contributor

left a comment

I‘m assuming you mean „an Authorization header is present😆

@Toflar Toflar changed the title Also make response private if an Authorization header is private Also make response private if an Authorization header is present Jul 17, 2019

@Toflar Toflar force-pushed the bugfix/response-private-on-authorization branch from f8e5556 to 64d847c Jul 17, 2019

@Toflar

This comment has been minimized.

Copy link
Member Author

commented Jul 17, 2019

Lol, yeah right. Nice find! Fixed 😊

@leofeyer leofeyer merged commit 4efe4c4 into 4.8 Jul 18, 2019

5 checks passed

Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
coverage/coveralls Coverage increased (+0.007%) to 86.957%
Details
@leofeyer

This comment has been minimized.

Copy link
Member

commented Jul 18, 2019

Thank you @Toflar.

@leofeyer leofeyer deleted the bugfix/response-private-on-authorization branch Jul 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.