Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved folderUrl setting to the root page #706

Merged
merged 4 commits into from Sep 3, 2019

Conversation

@aschempp
Copy link
Contributor

commented Sep 2, 2019

This basically does the following:

  • always enable folderPage for routing
  • only generate the folder URL alias depending on the root page setting

@aschempp aschempp added the feature label Sep 2, 2019

@aschempp aschempp added this to the 4.9 milestone Sep 2, 2019

aschempp and others added 3 commits Sep 2, 2019

@leofeyer leofeyer merged commit 59de0a3 into master Sep 3, 2019

5 checks passed

Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
coverage/coveralls Coverage remained the same at 86.211%
Details
@leofeyer

This comment has been minimized.

Copy link
Member

commented Sep 3, 2019

Thank you @aschempp.

@leofeyer leofeyer deleted the feature/folderUrl-root branch Sep 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.