Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order the page models by the order of candidates #744

Merged
merged 7 commits into from Sep 12, 2019

Conversation

@leofeyer
Copy link
Member

commented Sep 11, 2019

This PR fixes #740.

@leofeyer leofeyer added the defect label Sep 11, 2019

@leofeyer leofeyer added this to the 4.8 milestone Sep 11, 2019

@leofeyer leofeyer requested review from ausi and aschempp Sep 11, 2019

@leofeyer leofeyer self-assigned this Sep 11, 2019

@aschempp
Copy link
Contributor

left a comment

Can we please have a functional test (first)? Like

  1. commit failing functional test
  2. make PR with failing functional test
  3. rebase/pick this fix on top of a new branch based on top of the failing test
  4. create PR second with functional test and fix

This way we can see that this fix is actually correct 🤷‍♂

@leofeyer leofeyer force-pushed the bugfix/route-provider branch from ef469ef to bfbfb97 Sep 11, 2019

@leofeyer leofeyer force-pushed the bugfix/route-provider branch from bfbfb97 to 30fd341 Sep 11, 2019

@leofeyer leofeyer requested a review from aschempp Sep 11, 2019

@leofeyer leofeyer force-pushed the bugfix/route-provider branch from cc06c20 to 4326619 Sep 11, 2019

@leofeyer leofeyer force-pushed the bugfix/route-provider branch from 54e99d0 to 9c75d0c Sep 11, 2019

@leofeyer leofeyer force-pushed the bugfix/route-provider branch from 9c75d0c to 6bdc52d Sep 11, 2019

@leofeyer leofeyer requested a review from aschempp Sep 11, 2019

@ausi
ausi approved these changes Sep 12, 2019

@leofeyer leofeyer merged commit 43687e8 into 4.8 Sep 12, 2019

5 checks passed

Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
coverage/coveralls Coverage increased (+0.006%) to 86.264%
Details

@leofeyer leofeyer deleted the bugfix/route-provider branch Sep 12, 2019

@xchs

This comment has been minimized.

Copy link
Contributor

commented Sep 12, 2019

Thank you @leofeyer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.