Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The BackendSessionListener should actually be a UserSessionListener #1008

Closed
Toflar opened this issue Aug 7, 2017 · 5 comments
Closed

The BackendSessionListener should actually be a UserSessionListener #1008

Toflar opened this issue Aug 7, 2017 · 5 comments
Assignees
@leofeyer
Labels
bug
Milestone
4.4

Comments

@Toflar
Copy link
Member

Toflar commented Aug 7, 2017

...and also implement the logic for a FE member. Because if a page is currently already in the proxy cache, you won't get a fresh version if you log in as a front end member.
@leofeyer
Copy link
Member

leofeyer commented Aug 8, 2017

I'm struggling to reproduce this.

I have logged in in a separate browser window and reloaded the page (which is in the cache). I have been given the fresh page instead of the one from the cache.

@Toflar
Copy link
Member Author

Toflar commented Aug 8, 2017

Does not sound logical to me. It should fail. Can you debug why it does not load from the cache? It should because nobody is telling it it shouldn't 😄

@leofeyer leofeyer added the bug label Aug 9, 2017
@leofeyer leofeyer added this to the 4.4.3 milestone Aug 9, 2017
@leofeyer leofeyer self-assigned this Aug 9, 2017
leofeyer added a commit that referenced this issue Aug 9, 2017
@leofeyer
Also check for a front end user during header replay (see #1008).
9f10551
@leofeyer
Copy link
Member

leofeyer commented Aug 9, 2017

Fixed in 9f10551.

@leofeyer leofeyer closed this as completed Aug 9, 2017
@Toflar
Copy link
Member Author

Toflar commented Aug 9, 2017

Thank you!

@leofeyer
Copy link
Member

leofeyer commented Aug 9, 2017

Welcome you are. 😄

@leofeyer leofeyer modified the milestones: 4.4.3, 4.4 May 14, 2019
leofeyer added a commit that referenced this issue Nov 27, 2019
@leofeyer
Do not add the preview script when rebuilding the search index (see #…
018913c 
…1008)

Description
-----------

Fixes #942

Commits
-------

deb0313f Do not add the preview script when rebuilding the search index (see #942)
1f34292c Strip the preview script when rebuilding the search index
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leofeyer leofeyer

Labels
bug
Projects
None yet
Milestone
4.4
Development

No branches or pull requests
2 participants
@Toflar @leofeyer