Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The front end preview does not work properly #1033

Closed
xchs opened this issue Aug 20, 2017 · 8 comments
Closed

The front end preview does not work properly #1033

xchs opened this issue Aug 20, 2017 · 8 comments
Assignees
@leofeyer
Labels
bug
Milestone
4.4

Comments

@xchs
Copy link
Contributor

xchs commented Aug 20, 2017 •
edited
Loading

As of version 4.4.3 the Contao front end preview always redirects to the start page (index page) no matter what article or page is being viewed.

To reproduce in the Contao online demo:

  • Edit an article (e.g. "Media elements")
  • Open the front end preview
  • The preview shows the start page instead of the "Media elements" page
@leofeyer
Copy link
Member

That's another problem caused by the ref= parameter being added to the URL. It currently creates preview?ref=VWCeDoxa?page=55 instead of &page=55.

@leofeyer leofeyer added the bug label Aug 20, 2017
@leofeyer leofeyer added this to the 4.4.4 milestone Aug 20, 2017
@aschempp
Copy link
Member

What did we change in regards to the ref= parameter?

@xchs
Copy link
Contributor Author

xchs commented Aug 20, 2017

Maybe this one: e667934

@leofeyer leofeyer mentioned this issue Aug 21, 2017
Closed
@leofeyer leofeyer self-assigned this Aug 21, 2017
leofeyer added a commit that referenced this issue Aug 21, 2017
@leofeyer
Do not add the referer ID in the Template::route() method (see #1033).
800b164
@leofeyer
Copy link
Member

Fixed in 800b164.

@xchs
Copy link
Contributor Author

xchs commented Aug 21, 2017

Thanks a lot. It now works as expected.

Can we also get rid of the ?referer=… parameter that gets added to the URL when clicking on the back end link in the install tool? Or is this referer ID necessary for something that I don't see or know at the moment?

@leofeyer leofeyer mentioned this issue Aug 22, 2017
Closed
@leofeyer
Copy link
Member

The install tool link goes straight into the back end, so you don't have to log in if you are logged in already. If we changed it, the ?referer= parameter would disappear from the URL but you would have to log in every time.

@xchs
Copy link
Contributor Author

xchs commented Aug 22, 2017

Okay, thanks for the explanation. This makes sense, of course.

leofeyer added a commit that referenced this issue Aug 22, 2017
@leofeyer
Do not add the referer to the URL if there are no query parameters (see
be3a365 
#1033).
@leofeyer
Copy link
Member

leofeyer commented Aug 22, 2017 •
edited
Loading

Optimized in be3a365.

@leofeyer leofeyer modified the milestones: 4.4.4, 4.4 May 14, 2019
leofeyer pushed a commit that referenced this issue Dec 2, 2019
@Toflar @leofeyer
Disable auto cache control of the Symfony SessionListener (see #1033)
f405bf2 
Description
-----------

Fixes contao/contao#1028.

In fact, we don't need the default behaviour of Symfony because we qualify for "advanced usage" and our listener already correctly handles making responses private if needed.
I thought we need session stacking but that's not required because the SessionListener of SF correctly closes the session during `kernel.finish_request` which will cause our listener to correctly determine that the session was not started yet during the next `kernel.response`.

Commits
-------

cfdc1729 Disable auto cache control of the Symfony SessionListener
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leofeyer leofeyer

Labels
bug
Projects
None yet
Milestone
4.4
Development

No branches or pull requests
3 participants
@aschempp @leofeyer @xchs