Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Important part cannot be set within picker overlay #1093

Closed
fritzmg opened this issue Sep 20, 2017 · 5 comments
Closed

Important part cannot be set within picker overlay #1093

fritzmg opened this issue Sep 20, 2017 · 5 comments
Assignees
Labels
Milestone

Comments

@fritzmg
Copy link
Contributor

fritzmg commented Sep 20, 2017

If you go to the file manager within the picker overlay and edit an image, you are not able to set the important part with your cursor anymore. Instead, only the input fields to manually set the important part appear.

Possibly related to #1092 ?

@ausi
Copy link
Member

ausi commented Sep 20, 2017

I think this can be fixed with the following changes:

--- a/src/Resources/contao/themes/flexible/src/hover.js
+++ b/src/Resources/contao/themes/flexible/src/hover.js
@@ -192,8 +192,9 @@ var Theme = {
     * Set up the profile toggle
     */
    setupProfileToggle: function() {
-       var tmenu = $('tmenu'),
-             ul = tmenu.getElement('.level_2'),
+       var tmenu = $('tmenu');
+       if (!tmenu) return;
+       var ul = tmenu.getElement('.level_2'),
            h2 = tmenu.getElement('h2');
        if (!ul || !h2) return;

@leofeyer leofeyer added the bug label Sep 20, 2017
@leofeyer leofeyer added this to the 4.4.6 milestone Sep 20, 2017
@leofeyer leofeyer changed the title 4.4.5 important part cannot be set within picker overlay Important part cannot be set within picker overlay Sep 21, 2017
@dmolineus
Copy link
Contributor

This issue also occurs then editing content in the modal window (e.g. edit a form by clicking the edit wizard in the content element).

@ausi
Copy link
Member

ausi commented Sep 25, 2017

@dmolineus can you confirm that my changes also fixes your issue?

@dmolineus
Copy link
Contributor

@ausi Yes, it fixes the issue.

@leofeyer
Copy link
Member

Fixed in 21ef2c1. Thank you @ausi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants