-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always use rel="noreferrer noopener" linking to another site with target="_blank" #1125
Comments
|
I guess we should. I have noticed that TinyMCE already does. |
|
I have added |
|
However, there is a problem: Best way would be to decide if we would like to use noreferrer links or not. |
|
window.open should be fixed too. See this blog post a couple of days ago: https://pineco.de/security-and-performance-benefit-from-the-rel-noopener/ Related fix from the post is: @Xendiadyon did you got some more details about that problem? Google recommends that every link should had noopener als rel attr. See here https://developers.google.com/web/tools/lighthouse/audits/noopener |
|
I would recommend as well that we always use rel="noopener". But we should not use the "noreferrer". Because otherwise, tracking pages would not be able to read the referring page. This means, Google Analytics should know where the user is from. Usually, this is highly desired. In detail, we had two pages, the company page setting links for a specific action page, which was active only during a couple of weeks. We wanted to track how many users came from the company page to the action page - and through which pathways they made it to the action page. So: rel="noopener" should always be set. But rel="noreferrer" should only be used if explicitely decided. (Hint: We are using noreferrer, as some Firefox versions do not interpret correctly the noopener Tag) |
By whom? I do not desire that Google knows where I am coming from or where I am going! |
|
In user perspective, I agree. In marketing perspective, this information is essential :) |
|
Hopefully the GDPR will help to reduce these "essential marketing practices" in the future. |
|
If you need the referrer for analytics, don’t use |
|
If this works, this would be a great specific workaround! |
|
Fixed in f9d13e2. |
Description ----------- See https://symfony.com/blog/new-in-symfony-4-4-simpler-event-listeners Commits ------- a31e80ba Simplify the event registration cf8a71a6 Use an __invoke() method in the MergeHttpHeadersListener class 4a95e51b Specify the method name instead of the event if a listener does not have an __invoke() method ea53f5a2 Fix the unit tests
Description ----------- Changed method signature in #1125. Commits ------- 4387e96d Renamed method after changing its signature
Should we (automatically) add an
rel="noreferrer noopener"attribute for alltarget="_blank"links?See:
The text was updated successfully, but these errors were encountered: