Do not log "invalid request token" exceptions

[leofeyer]

@contao/developers How can we stop certain exceptions such as "invalid request token" from cluttering up the log files?

[aschempp]

By not logging them? 😂
https://github.com/contao/core-bundle/blob/master/src/EventListener/PrettyErrorScreenListener.php#L329

[leofeyer]

You mean a hardcoded list? What if someone wants to add more entries?

[aschempp]

We could make it configurable in the bundle. But how would you prevent logging in a regular Symfony application?

[leofeyer]

The more I think about it, I come to the conclusion that we should only log unknown exceptions.

Do not log the known exceptions:

    private static $mapper = [
        ForwardPageNotFoundException::class => 'forward_page_not_found',
        IncompleteInstallationException::class => 'incomplete_installation',
        InsecureInstallationException::class => 'insecure_installation',
        InvalidRequestTokenException::class => 'invalid_request_token',
        NoActivePageFoundException::class => 'no_active_page_found',
        NoLayoutSpecifiedException::class => 'no_layout_specified',
        NoRootPageFoundException::class => 'no_root_page_found',
    ];

And do not log the back end exceptions, because both the known exceptions and the back end exceptions are primarily user error which provide little value when added in the log file, don't you think?

[leofeyer]

Well, we should log the ForwardPageNotFoundException::class exception, because this is a configuration error that needs to be fixed.

[Toflar]

I agree, only ForwardPageNotFoundException is really relevant here.

[leofeyer]

Implemented in f72251f.