Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PrettyErrorScreenListener triggered on non-Contao routes #1149

Closed
Toflar opened this issue Oct 18, 2017 · 4 comments
Closed

PrettyErrorScreenListener triggered on non-Contao routes #1149

Toflar opened this issue Oct 18, 2017 · 4 comments
Assignees
Labels
Milestone

Comments

@Toflar
Copy link
Member

Toflar commented Oct 18, 2017

When I register a custom route, the PrettyErrorScreenListener is still triggered. I think we should use the scope matcher here too. Wdyt?

@aschempp
Copy link
Member

aschempp commented Oct 18, 2017 via email

@Toflar
Copy link
Member Author

Toflar commented Oct 18, 2017

It does not check the scope, otherwise I would not have opened this issue?

@bytehead
Copy link
Member

We had the same problem as well.

@leofeyer leofeyer added the bug label Oct 19, 2017
@leofeyer leofeyer added this to the 4.4.8 milestone Oct 19, 2017
@leofeyer leofeyer self-assigned this Nov 9, 2017
@leofeyer
Copy link
Member

leofeyer commented Nov 9, 2017

Fixed in 9abe32c.

@leofeyer leofeyer closed this as completed Nov 9, 2017
@leofeyer leofeyer modified the milestones: 4.4.8, 4.4 May 14, 2019
leofeyer added a commit that referenced this issue Jan 3, 2020
Description
-----------

Fixes #789

Commits
-------

e0f6bfe4 Fix the tl_files.source label (see #789)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants