Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<strong> Element in nav_default but not in mod_breadcumb #1154

Closed
asaage opened this issue Oct 21, 2017 · 5 comments
Closed

<strong> Element in nav_default but not in mod_breadcumb #1154

asaage opened this issue Oct 21, 2017 · 5 comments
Assignees
@leofeyer
Labels
feature
Milestone
4.5

Comments

@asaage
Copy link

asaage commented Oct 21, 2017

Updating from 3.5 intallation i noticed that the nav_default template uses the <strong> instead of <span> tag for the active Item.
In the commit-history i could not find when or why this has changed.
Of course it's an easy fix to adjust the template (or fix my css) but i don't really think the use of <strong> is semantically correct here.
@fritzmg
Copy link
Contributor

fritzmg commented Oct 21, 2017

It is semantically correct. See

@asaage
Copy link
Author

asaage commented Oct 21, 2017

Alright - i'm not shure why one would like to emphasize something that has already been cklicked on and offers no further actions but it should be strong in mod_breadcrumb then too.

@asaage asaage closed this as completed Oct 21, 2017
@fritzmg
Copy link
Contributor

fritzmg commented Oct 21, 2017

Alright - i'm not shure why one would like to emphasize something that has already been cklicked on and offers no further actions

It's about the semantic meaning of the HTML markup, not about click actions. <strong> semantically emphasises its content, signifying the currently active element in this case.

@fritzmg
Copy link
Contributor

fritzmg commented Oct 21, 2017

You should reopen and rename the ticket for mod_breadcrumb.

@asaage asaage reopened this Oct 21, 2017
@asaage asaage changed the title <strong>Element in nav_default template <strong> Element in nav_default but not in mod_breadcumb Oct 21, 2017
@leofeyer leofeyer added this to the 4.5.0 milestone Oct 22, 2017
@leofeyer leofeyer self-assigned this Nov 20, 2017
leofeyer added a commit that referenced this issue Nov 20, 2017
@leofeyer
Also use STRONG instead of SPAN in the breadcrumb menu (see #1154).
acd841e
@leofeyer
Copy link
Member

Changed in acd841e.

leofeyer pushed a commit that referenced this issue Jan 7, 2020
@rabauss @leofeyer
Get the universal picker URL parameters via own method (see #1154)
d01e22a 
Description
-----------

see: contao/contao#579 (comment)

Commits
-------

f02c53da Get universal picker url parameters via own method
65cdb430 Update doc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leofeyer leofeyer

Labels
feature
Projects
None yet
Milestone
4.5
Development

No branches or pull requests
3 participants
@leofeyer @asaage @fritzmg