Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"The form could not be sent" added to search results #1194

Closed
fritzmg opened this issue Nov 16, 2017 · 2 comments
Closed

"The form could not be sent" added to search results #1194

fritzmg opened this issue Nov 16, 2017 · 2 comments
Assignees
@leofeyer
Labels
bug
Milestone
4.4

Comments

@fritzmg
Copy link
Contributor

fritzmg commented Nov 16, 2017 •
edited
Loading

When a page contains a form and there are errors in the form, the page title will be set to

The form could not be sent - Lorem ipsum dolor

See Form.php#L271. However, sometimes this page title is also put into the search index. Meaning the page title for the search result from that page will also say The form could not be sent - Lorem ipsum dolor. Shouldn't

$objPage->noSearch = 1;
$objPage->cache = 0;

be added here as well?
@aschempp
Copy link
Member

I think we should generally not search-index any POST requests?

@leofeyer leofeyer added the bug label Nov 17, 2017
@leofeyer leofeyer added this to the 4.4.9 milestone Nov 17, 2017
@leofeyer leofeyer self-assigned this Dec 14, 2017
leofeyer added a commit that referenced this issue Dec 14, 2017
@leofeyer
Only add pages requested via GET to the search index (see #1194).
7e61aca
@leofeyer
Copy link
Member

We should not. Fixed in 7e61aca.

@leofeyer leofeyer modified the milestones: 4.4.9, 4.4 May 14, 2019
leofeyer pushed a commit that referenced this issue Jan 16, 2020
@bytehead @leofeyer
Show the correct error message if a wrong 2FA token is entered (see #…
3e6bdd6 
…1194)

Description
-----------

This fixes #1186.

Commits
-------

4a2080ef Fix wrong exception
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leofeyer leofeyer

Labels
bug
Projects
None yet
Milestone
4.4
Development

No branches or pull requests
3 participants
@aschempp @leofeyer @fritzmg