-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inserttags from modules are working but logged as "unknown inserttag" #1295
Comments
|
I am using a lot of custom insert tags in my own projects and I cannot reproduce this in any. How does your code look like and what is the exact log message? |
|
Its a small util. you can find the code here: It is used to reference a module by an alias instead of an db ID The message is: |
|
How did you register the callback? |
|
it is registered at https://github.com/guavestudios/contao-insertbyalias/blob/14bf13e0a0d71b414437917bdfbab6a28fe871bf/config/config.php#L4 The hook itself works and renders the module. Log is written in current tree at:
|
|
Ok, no log entries have been written however the Symfony toolbar revealed them. Fixed in 937c936. |
|
Yeah, i've tried the patch and it solved the the Toolbar Error. Thanks for fixing! |
Description ----------- Fixes #1252 Commits ------- f75ed427 Handle removed search indexer services f6dd5f98 Update core-bundle/tests/DependencyInjection/Compiler/CrawlerPassTest.php



If an inserttag hook is registerd in replaceInsertTags it works, but it logs that there is an unknown insert tag.
it should not be logged as unknown since the module has "defined" it.
Contao Version: 4.4.12 (composer)
PHP: 7.1.9
Problably problem found in vendor\contao\core-bundle\src\Resources\contao\library\Contao\InsertTags.php:959 (break Statement)
Solution: Break out of outer switch statement if inserttag was replaced correctly.
The text was updated successfully, but these errors were encountered: