Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing custom CSS classes for backend navigation items #1357

Closed
qzminski opened this issue Feb 6, 2018 · 2 comments
Closed

Missing custom CSS classes for backend navigation items #1357

qzminski opened this issue Feb 6, 2018 · 2 comments
Assignees
Labels
Milestone

Comments

@qzminski
Copy link
Member

qzminski commented Feb 6, 2018

Since Contao 4.5 the backend menu items lack the custom CSS classes functionality. It was present in 4.4 but is no longer in the new Twig template implementation.

Contao 4.4: https://github.com/contao/core-bundle/blob/4.4/src/Resources/contao/templates/backend/be_main.html5#L64
Contao 4.5: https://github.com/contao/core-bundle/blob/4.5/src/Resources/views/Backend/be_menu.html.twig#L7

Some extensions rely on this, e.g. easy_themes that is adding a custom CSS class via getUserNavigation hook:
https://github.com/terminal42/contao-easy_themes/blob/master/EasyThemes.php#L278

Issue originated from terminal42/contao-easy_themes#38

@Toflar
Copy link
Member

Toflar commented Feb 6, 2018

/cc @sheeep

@leofeyer leofeyer added the bug label Feb 6, 2018
@leofeyer leofeyer added this to the 4.5.4 milestone Feb 6, 2018
@leofeyer leofeyer self-assigned this Feb 14, 2018
@leofeyer
Copy link
Member

Fixed in b5fc53d.

@leofeyer leofeyer modified the milestones: 4.5.4, 4.5 May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants