Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem when maintenance mode is enabled #1492

Closed
netzarbeiter opened this issue Apr 19, 2018 · 10 comments
Closed

Problem when maintenance mode is enabled #1492

netzarbeiter opened this issue Apr 19, 2018 · 10 comments
Assignees
Labels
Milestone

Comments

@netzarbeiter
Copy link
Member

After updating to Contao 4.4.18 still the same behaviour as described in Ticket #1370.

@joeherold
Copy link

I realized, that the {{ua::class}} token also is empty when maintaince mode is activated. Tested in Contao 4.5.8

@leofeyer
Copy link
Member

As discussed in Mumble on May 17th, @Toflar will check why the PR does not work.

@leofeyer leofeyer added this to the 4.4.19 milestone May 17, 2018
@Toflar
Copy link
Member

Toflar commented May 17, 2018

Status update: Cannot reproduce on fresh 4.4.18 install. Works like a charm.

@Toflar
Copy link
Member

Toflar commented May 17, 2018

Okay, I have a reproducible use case and the source now but no idea why it happens and how to fix it yet. I'm pretty sure it's not a Contao bug though.

@joeherold
Copy link

@Toflar: hahahaha

@joeherold
Copy link

@Toflar: I am just guessing, but I realized, that the „global $objPage“ is not available in insert Tags.

@Toflar
Copy link
Member

Toflar commented May 17, 2018

No, it‘s related to IP handling and routing but I‘ll need a quiet minute to look into it :)

@aschempp
Copy link
Member

I‘ll need a quiet minute to look into it :)

Which will be hard, given the fact that they are tearing up the streets in front of our office (for the next 6 months) 😡

@Toflar
Copy link
Member

Toflar commented May 18, 2018

After 5h of debugging together with @aschempp, I think we found the source of the problem in Symfony. Here we go: symfony/symfony#27309

@leofeyer
Copy link
Member

leofeyer commented Jun 15, 2018

As an intermediate fix, I have whitelisted local requests in contao/manager-bundle@c42899b as proposed in #1370. This will not work for Varnish or other "external" HTTP caches, but regarding this we can only wait for symfony/symfony#27309 to get merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants