duplicate IDs for formfields

[asaage]

In #957 there is dicussion about same form multiple times on a page which causes invalid html because of duplicate IDs.

I noticed, that the ce_comment-form and the mod_registration-form
both use id="ctrl_email"
whereas the mod_unsubscribe-form uses something like id="ctrl_email_xy" (xy being the module-ID)

It would be nice if i could use both forms on the same page and still have valid html.

[m-vo]

True, but there are the same problems like in the referenced ticket that changing them would imply a BC break.

You can still alter the template. Maybe this is a known limitation, then.

[fritzmg]

Not being able to put two completely different forms on the same page (by default) is rather weird though.

[asaage]

The fields are not inside the ce_comment-/mod_registration Template.
I'm not quite shure but i think adding a unique id somewhere here could work.
I don't see why this should be a BCbreak (except for possible css-related things).

[asaage]

The same problem exists for id="ctrl_website" if that is activated in the registration-module.

[leofeyer]

Adding the module ID to the registration form and the parent ID to the comments form fixes only 99% of the cases (which is good enough I guess). If the parent ID of the comments form happens to be the same as the module ID of the registration form, the problem still exists.

[leofeyer]

Fixed in 9d87aa2 and contao/comments-bundle@ded4b33.

[frontendschlampe]

May there's a possibility to add a special prefix each module, e.g. nXXX for newsletter, cXXX for comments and fXXX for forms? But I think, it should be a problem, because we have only numeric ID's in Contao, isn't it?

[leofeyer]

A prefix would not solve the problem, either, if there were two comment forms on the same page.

[fritzmg]

I agree that this is good enough. Having two comment forms with the same parent would be a weird setup anyway, wouldn't it.

[frontendschlampe]

A prefix would not solve the problem, either, if there were two comment forms on the same page.

I think 2 comment modules will have different ID's because they're 2 different modules. With prefix you can solve the problem, that a form and a comment module will not have the same ID.

But no problem ... it's ok like it is. If I have the case, that I have 2 modules with same ID I can change the ID of one module.