Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mod_login: "cols" remove this field or add it as css-class #1577

Closed
asaage opened this issue Jun 20, 2018 · 5 comments
Closed

mod_login: "cols" remove this field or add it as css-class #1577

asaage opened this issue Jun 20, 2018 · 5 comments
Assignees
Labels
Milestone

Comments

@asaage
Copy link

asaage commented Jun 20, 2018

The current mod_login offers to choose between one or two columns.
https://demo.contao.org/contao?do=themes&table=tl_module&id=4

I don't realy think it is something we need - but if we keep this field it should be referenced in the template as a css-class.

related issue

@leofeyer leofeyer added this to the 4.6.0 milestone Jun 26, 2018
@leofeyer leofeyer modified the milestones: 4.6.0, 4.4.21 Jun 27, 2018
@leofeyer
Copy link
Member

The field can be removed. We are no longer using it as of Contao 4.0.

@ausi
Copy link
Member

ausi commented Jun 27, 2018

Every installation that currently uses $this->cols in the login template would break if we remove this field.

It would also break the SQL website template import for current SQL files.

IMO we must not change this in a bugfix release.

@leofeyer leofeyer modified the milestones: 4.4.21, 4.6.0 Jun 27, 2018
@leofeyer leofeyer added feature and removed bug labels Jun 27, 2018
@leofeyer
Copy link
Member

Agreed. But we can remove it in Contao 4.6, right?

@ausi
Copy link
Member

ausi commented Jun 27, 2018

Yes, as we don’t guarantee backwards compatibility for templates, I think we can remove it in 4.6.

@leofeyer
Copy link
Member

Removed in 5fcee7b.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants