Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the insert tag regex #472

Closed
leofeyer opened this issue Apr 8, 2016 · 1 comment

Comments

@leofeyer
Copy link
Member

commented Apr 8, 2016

Now: '/{{(([^{}]*|(?R))*)}}/'
Then: '/{{((?:[^{}]*|(?R))*)}}/'

The change will affect the increment of the $_rit variable, which is why it is not backwards compatible. We are currently incrementing by 3 and will be incrementing by 1 after the change.

The change should save us some RAM though.

@leofeyer leofeyer added this to the 5.0.0 milestone Apr 8, 2016

@leofeyer leofeyer removed this from the 5.0.0 milestone Apr 8, 2016

@leofeyer

This comment has been minimized.

Copy link
Member Author

commented Apr 8, 2016

No longer relevant as soon as #473 has been merged.

@leofeyer leofeyer closed this Apr 8, 2016

leofeyer added a commit that referenced this issue Jul 12, 2019
Remove a page's search index entries when its alias is changed (see #472
)

Description
-----------

**How to reproduce the issue:**

* Create a page with the alias `foo`.

* Once you call `example.test/foo.html`, the page gets an entry in `tl_search`.

* Now change the alias to `bar`.

Currently, the entry with the now-outdated URL remains in `tl_search`, which means it shows up in the search results. It only gets removed once you call the outdated URL and get a 404, e. g. by visiting the outdated search result listing.

Also note that if you change only the alias, the page with the new URL does not get added once you visit it. If you change the alias and, e. g., the title, the new URL does get added, but the old one still remains.

**Suggested solution:**

A page's search index entries already get removed when the page is deleted[1]. We should do the same when the alias changes.

---
[1] contao/contao@ba075d0

Commits
-------

7274f39f Remove a page's search index entries when its alias is changed
507c26c6 Purge search index on alias change: Check for new page by VERSION_NUMBER
f4429a14 Remove page version check altogether
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.