Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop popupWidth and popupHeight #727

Closed
leofeyer opened this issue Mar 18, 2017 · 5 comments
Closed

Drop popupWidth and popupHeight #727

leofeyer opened this issue Mar 18, 2017 · 5 comments
Assignees
Labels
Milestone

Comments

@leofeyer
Copy link
Member

We are currently using popupWidth and popupHeight to calculate the size of the modal window in the file manager. However, we are always showing the modal window in full height as of Contao 3.5.25 due to contao/core#8631, so we actually do not need popupWidth and popupHeight anymore.

I would like to drop them entirely in Contao 4.4, because calculating the width and height of every image in the file tree is quite expensive – especially if the results are no longer used.

@contao/developers Any objections?

@leofeyer leofeyer added this to the 4.4.0 milestone Mar 18, 2017
@leofeyer leofeyer self-assigned this Mar 18, 2017
@aschempp
Copy link
Member

Can you point to the code where popupWidth and popupHeight are used? I can't see a reason not to drop it.

@leofeyer
Copy link
Member Author

@Toflar
Copy link
Member

Toflar commented Mar 20, 2017

I don't see why we'd need this really...

@aschempp
Copy link
Member

Clever you, I guess we can remove it 😛

@leofeyer
Copy link
Member Author

Removed in 71c292b.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants