Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.4] Use kernel.project_dir and require Symfony 3.3 #758

Closed
Toflar opened this issue Apr 11, 2017 · 4 comments
Closed

[4.4] Use kernel.project_dir and require Symfony 3.3 #758

Toflar opened this issue Apr 11, 2017 · 4 comments
Assignees
Labels
Milestone

Comments

@Toflar
Copy link
Member

Toflar commented Apr 11, 2017

http://symfony.com/blog/new-in-symfony-3-3-a-simpler-way-to-get-the-project-root-directory?utm_source=feedburner&utm_medium=twitter&utm_campaign=Feed%3A+symfony%2Fblog+%28Symfony+Blog%29

@leofeyer
Copy link
Member

+1 for using kernel.project_dir.

@contao/developers Do we want to keep our contao.root_dir parameter or remove it in favor of kernel.project_dir? Theoretically, contao.root_dir allows us to place the Contao folders into a completely different folder – but who will ever do this?

@leofeyer leofeyer added this to the 4.4.0 milestone Apr 12, 2017
@ausi
Copy link
Member

ausi commented Apr 12, 2017

I think we should get rid of contao.root_dir and use the kernel.project_dir instead.

@aschempp
Copy link
Member

We should definitely not add contao.root_dir (which should only have been added in 4.4).

@leofeyer
Copy link
Member

leofeyer commented May 2, 2017

See #803.

@leofeyer leofeyer closed this as completed May 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants