[RTM] Display form fieldsets as wrappers in the backend view. #1102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmolineus
force-pushed
the
feature/fieldset-wrappers
branch
from
b269eca
to
bda807f
Compare
|
Oh yes finally 😁 |
|
Migration script provided with contao/installation-bundle#69 |
dmolineus
changed the title
|
This will break some extensions though, e.g. terminal42/contao-conditionalformfields |
|
It's not API and I think it won't be really a problem to adjust the extension to it ;) |
|
I know, just saying ;) |
leofeyer
force-pushed
the
develop
branch
3 times, most recently
from
e37e989
to
dad087d
Compare
dmolineus
changed the title
leofeyer
force-pushed
the
develop
branch
12 times, most recently
from
4c8802b
to
4f5e7b2
Compare
leofeyer
force-pushed
the
develop
branch
2 times, most recently
from
495cb11
to
1358688
Compare
leofeyer
force-pushed
the
develop
branch
3 times, most recently
from
da44f69
to
90840d3
Compare
ghost
mentioned this pull request
ghost
closed this
|
Thank you @dmolineus. |
leofeyer
pushed a commit
that referenced
this pull request
Dec 16, 2019
…(see #1102) Description ----------- According to the phpdoc comment, `Response::getContent()` may also return `false`. Commits ------- ce71f642 Make sure we have the correct type when a search document is created 0758a2af Merge branch 'master' into bugfix/fix-typehint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrapper elements provides a cleaner view of complex elements in the parent view. As the feature is not limited to CEs it would be nice to use it for form fieldsets as well.
If this PR is accepted I'll provide the missing tasks as well.