Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MooTools version for googleapis. #1391

Closed

Conversation

richardhj
Copy link
Member

@richardhj richardhj commented Feb 20, 2018

MooTools gets not loaded in the frontend because the ajax.googleapis.com server replied with an 404.

  1. There is obviously a typo / copy-paste error.
  2. I had to trim version 1.6.0.5 (package version of contao-components/mootools) to 1.6.0 in order to have a valid URI.
  3. This is a Contao 4.5 exclusive bug.

@xchs
Copy link
Contributor

xchs commented Feb 20, 2018

Could you also target the PR at the 4.5 branch?

@richardhj
Copy link
Member Author

The diff then consists of more commits.

@xchs
Copy link
Contributor

xchs commented Feb 20, 2018

It's because of the Trunk-based development strategy that was recently switched to.

@leofeyer
Copy link
Member

Fixed in 6f67345. Thank you @richardhj for debugging the issue.

@leofeyer leofeyer closed this Feb 20, 2018
@richardhj richardhj deleted the hotfix/googleapis-mootools branch February 20, 2018 22:40
@leofeyer leofeyer modified the milestones: 4.5.5, 4.5 May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants