Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RTM] Add template blocks to be_login.php #1424

Merged
merged 2 commits into from
Apr 10, 2018
Merged

[RTM] Add template blocks to be_login.php #1424

merged 2 commits into from
Apr 10, 2018

Conversation

CMSworker
Copy link
Contributor

Added blocks like here:
https://github.com/contao/core-bundle/blob/master/src/Resources/contao/templates/backend/be_main.html5

With blocks it should be possible to add content in a child template (Template inheritance) like described in the book here: https://docs.contao.org/books/manual/4.0/en/04-managing-content/templates.html

Use case: Wanted to add a custom logo with CSS in the Login page...

Added blocks like here:
https://github.com/contao/core-bundle/blob/master/src/Resources/contao/templates/backend/be_main.html5

With blocks it should be possible to add content in a child template (Template inheritance) like described in the book here: https://docs.contao.org/books/manual/4.0/en/04-managing-content/templates.html

Use case: Wanted to add a custom logo with CSS in the Login page...
@leofeyer leofeyer added this to the 4.6.0 milestone Mar 13, 2018
@leofeyer leofeyer changed the title Add template blocks to be_login.php [RTM] Add template blocks to be_login.php Mar 15, 2018
@leofeyer leofeyer merged commit 88d55fc into contao:master Apr 10, 2018
@leofeyer
Copy link
Member

Thank you @CMSworker.

Copy link
Member

@ausi ausi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @leofeyer

<meta name="viewport" content="width=device-width,initial-scale=1.0,shrink-to-fit=no">
<meta name="referrer" content="origin">
<meta name="robots" content="noindex,follow">
<?php $this->block('meta'); ?>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be $this->endblock()

</main>
<?= $this->messages ?>
</div>
<?php $this->block('container'); ?>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be $this->endblock()

@leofeyer
Copy link
Member

Fixed in 552e627. Thank you for your careful review @ausi .

leofeyer added a commit that referenced this pull request Mar 2, 2020
Description
-----------

This reverts the changes from #1332 so TinyMCE is initialized correctly when loaded in a sub-palette (see contao/contao#1313 (comment)).

Commits
-------

9ee26adb Revert the document.write() changes (see #1313)
1a4dada0 Add a comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants