[RTM] allow multi root and multi page search

[fritzmg]

These changes allow you to expand/limit the search to multiple pages or website roots. This enables you to:

• limit the search to multiple pages and its children - instead of just one page and its children
• expand the search over multiple website roots - instead of being restricted to the current website root

The changes are fairly simple and straight forward. I tagged it as RFC since I am unsure whether the use of a new field called searchPages is really necessary. I decided to not use the existing pages field, since the sort order does not matter. Though may be I should simply alter the DCA in a load_callback, similar to tl_content::setSingleSrcFlags? Then the pages field could be reused for this.

[aschempp]

Do I understand correctly that child pages of the selected ones are searched automatically? The field description does not mention that, maybe that would be useful?

Generally, I like the idea, have you tested whether the search result module also generates absolut links to the potential foreign domains?

[fritzmg]

Do I understand correctly that child pages of the selected ones are searched automatically? The field description does not mention that, maybe that would be useful?

Yes, child pages are searched automatically - as it's already the case in the current implementation when you select a reference page. The current field description doesn't mention it either:

Reference page

Please choose the reference page from the site structure.

However that field is shared with multiple modules, so the description has to be generic. We can choose a more descriptive one here, since it's its own field. Unless we switch to the pages field.

Generally, I like the idea, have you tested whether the search result module also generates absolut links to the potential foreign domains?

Yes :). This already worked anyway (if you set the reference page to a website root of another domain for example).

[leofeyer]

I'm pro reusing the pages field if possible.

[Toflar]

I'm pro reusing the pages field if possible.

Same here. Also I don't really think it is a problem if you can order pages. Who cares 😄

[fritzmg]

Alright, I'll update the PR accordingly :)

[fritzmg]

PR updated. I had to use a load_callback anyway, because the pages field is mandatory by default (which it should not be for the search module).

[Toflar]

Excellent work!

[leofeyer]

This is unnecessarily complex. Why not the following?

if ($dc->activeRecord && $dc->activeRecord->type == 'search')
{
    $GLOBALS['TL_DCA'][$dc->table]['fields'][$dc->field]['eval']['mandatory'] = false;
    unset($GLOBALS['TL_DCA'][$dc->table]['fields'][$dc->field]['eval']['orderField']);
}

BTW, is it really necessary to unset the order field?

[fritzmg]

This is unnecessarily complex.

True, it's unnecessarily complex. I used the same code as in tl_content::setSingleSrcFlags, in case more different changes would be necessary. I'll change it as suggested.

BTW, is it really necessary to unset the order field?

No, it's only for aesthetics 😁

[leofeyer]

Thank you @fritzmg.