Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reduce memory consumption during sitemap generation #1549

Merged
merged 1 commit into from
Jun 13, 2018
Merged

reduce memory consumption during sitemap generation #1549

merged 1 commit into from
Jun 13, 2018

Conversation

fritzmg
Copy link
Contributor

@fritzmg fritzmg commented Jun 9, 2018

@leofeyer leofeyer added the bug label Jun 11, 2018
@leofeyer leofeyer added this to the 4.4.19 milestone Jun 11, 2018
@leofeyer leofeyer merged commit 580ee42 into contao:4.4 Jun 13, 2018
@leofeyer
Copy link
Member

Thanks a lot for debugging this @fritzmg. The fix might be a one-liner only, but finding the problem took several hours.

@leofeyer leofeyer mentioned this pull request Jun 13, 2018
Closed
@fritzmg fritzmg deleted the patch-2 branch June 13, 2018 08:15
@leofeyer leofeyer modified the milestones: 4.4.19, 4.4 May 14, 2019
@baumannsven baumannsven mentioned this pull request May 30, 2019
Open
6 tasks
leofeyer pushed a commit that referenced this pull request Mar 30, 2020
@bytehead
Dynamically configure the TokenChecker service (see #1549)
5f9b406 
Description
-----------

| Q                | A
| -----------------| ---
| Fixed issues     | #1548
| Docs PR or issue | contao/docs#307

With `role_hierarchy` configured in Symfony security `config/packages/security.yaml`, the `security.access.simple_role_voter` gets removed:

```                                                                                           
The service "contao.security.token_checker" has a dependency 
on a non-existent service "security.access.simple_role_voter".
```

See here:
https://github.com/symfony/symfony/blob/8397eb79e003c52b93339c34d9bcafe4848e82c2/src/Symfony/Bundle/SecurityBundle/DependencyInjection/SecurityExtension.php#L165-L175

Commits
-------

69f3c705 Dynamically configure the token checker
9772c231 Fix yoda condition while comparing with lesser/greater operator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Toflar Toflar Toflar approved these changes

Assignees

@fritzmg fritzmg

Labels
bug
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
3 participants
@fritzmg @leofeyer @Toflar