Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RTM] Add page picker for meta fields in file manager #1568

Merged
merged 4 commits into from
Jun 19, 2018

Conversation

ausi
Copy link
Member

@ausi ausi commented Jun 16, 2018

As requested in contao/core#7169

metadata-picker

@aschempp
Copy link
Member

Great idea, but are you sure we don't want to keep the existing design and have the icon after the field (by shortening the Link field)?

@leofeyer
Copy link
Member

I actually like the new design a lot more. We should adjust the other fields as well. 😄

@ausi
Copy link
Member Author

ausi commented Jun 18, 2018

are you sure we don't want to keep the existing design and have the icon after the field (by shortening the Link field)?

This way it was much easier to implement because of the HTML structure of the meta wizard. ☺️

@leofeyer leofeyer added this to the 4.6.0 milestone Jun 18, 2018
@leofeyer
Copy link
Member

Changing it everywhere only works for text fields:

It does not work for drop down menus:

So now we can either

a) change the meta wizard only
b) change all text fields
c) leave everything as it is (and adjust the meta wizard).

@contao/developers What do you prefer?

@Toflar
Copy link
Member

Toflar commented Jun 18, 2018

c) leave everything as it is (and adjust the meta wizard).

@ausi
Copy link
Member Author

ausi commented Jun 18, 2018

c

1 similar comment
@aschempp
Copy link
Member

c

@leofeyer leofeyer merged commit 6a58383 into contao:master Jun 19, 2018
@leofeyer
Copy link
Member

Thank you @ausi.

@leofeyer
Copy link
Member

I have tried to implement c) but it looks even worse:

I therefore leave this as is for the moment.

@frontendschlampe
Copy link
Contributor

I agree that it looks not perfect, but in this case the functionality is much more important, than the design. It's another point on to do list for backend redesign. ;-)

leofeyer added a commit that referenced this pull request Mar 27, 2020
Description
-----------

| Q                | A
| -----------------| ---
| Fixed issues     | Fixes #1505
| Docs PR or issue | -

Commits
-------

a65bafd7 Add a missing space when generating global buttons
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants