Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Feature/new backend breadcrumb trail #623

Merged
merged 8 commits into from
May 17, 2017

Conversation

agoat
Copy link
Contributor

@agoat agoat commented Nov 15, 2016

This is the PR to #602 to handle unlimited child tables in the breadcumb trail.

It goes recursively through all the parent tables and trys to add the table name and the objects title or name.
If a table name is shown or not can be controlled whether there is a translation or not.
I also added a suggestion to style the table and the object names differently for a better readability.

Additionally extra translation should be added in the contao/news-bundle to show the tables name (in modules.xlf):

      <trans-unit id="MOD.tl_news">
        <source>Articles</source>
      </trans-unit>

If someone want to see this in action, I can send the login data for my dev server via email.

agoat pushed a commit to agoat/contao-customcontentelements-bundle that referenced this pull request Nov 17, 2016
@agoat agoat changed the title Feature/new backend breadcrumb trail [RFC] Feature/new backend breadcrumb trail Nov 24, 2016
}

// Add the beadcrumb trail in reverse order
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: breadcrumb

@leofeyer
Copy link
Member

@contao/developers /cc

@Toflar
Copy link
Member

Toflar commented Mar 20, 2017

Haven't tested it but looks neat! 👍 Thanks for contributing @agoat! I was just thinking about whether this needs to be modifiable/extensible somehow. But I haven't had the use case yet and we could still add an event later on if we want to.

@aschempp
Copy link
Member

Thanks! A quick code review looks good to me 😎
There are a few indentation issues (especially in the XLIFF) but these are minor things, @leofeyer will fix the coding style anyway ^^

@agoat
Copy link
Contributor Author

agoat commented Mar 20, 2017

Just a quick example of how it look like:
backend-breadcumb-trail1

And a very extreme one using circular parent tables (thats why I have made this PR):
backend-breadcumb-trail2

@leofeyer leofeyer force-pushed the develop branch 6 times, most recently from cd4aa42 to 51a60f7 Compare May 12, 2017 11:08
@leofeyer leofeyer self-assigned this May 17, 2017
@leofeyer leofeyer added this to the 4.4.0 milestone May 17, 2017
@leofeyer leofeyer merged commit a6740f4 into contao:develop May 17, 2017
@leofeyer
Copy link
Member

Thank you @agoat. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants