Use the same path roots when calling makePathRelative #752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
November 30, 2016 15:06
Merge contao/corea-bundle
Merge contao/core-bundle
|
@ausi made a PR in symfony/symfony symfony/symfony#22321. We decided that it's a bug in symfony. So this change will not be needed after symfony fixes the bug. |
ausi
approved these changes
Apr 12, 2017
leofeyer
pushed a commit
that referenced
this pull request
Apr 19, 2017
leofeyer
added a commit
that referenced
this pull request
Sep 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to #751 and fixes the (wrong) use of the
makePathRelativemethod in theSymlinkUtilclass to be compatible with Symfony 3.2.7.