[RTM] Use the file meta data by default when adding an image #807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Default form:
Form with the "Overwrite meta data" option set:
|
This was referenced May 3, 2017
Closed
leofeyer
changed the title
|
This PR is ready to merge now IMHO. |
Toflar
suggested changes
May 3, 2017
| */ | ||
| public static function addFileMetaInformationToRequest($strUuid, $strPtable, $intPid) | ||
| { | ||
| @trigger_error('Using Backend::addFileMetaInformationToRequest() has been deprecated and will no longer work in Contao 5.0.', E_USER_DEPRECATED); |
There was a problem hiding this comment.
Nothing. The elements now directly use the meta data, so we do not need this workaround anymore.
Toflar
approved these changes
May 3, 2017
leofeyer
added a commit
to contao/calendar-bundle
that referenced
this pull request
May 3, 2017
leofeyer
added a commit
to contao/faq-bundle
that referenced
this pull request
May 4, 2017
leofeyer
added a commit
to contao/faq-bundle
that referenced
this pull request
May 4, 2017
leofeyer
added a commit
to contao/faq-bundle
that referenced
this pull request
May 4, 2017
leofeyer
added a commit
to contao/news-bundle
that referenced
this pull request
May 4, 2017
leofeyer
added a commit
to contao/faq-bundle
that referenced
this pull request
May 4, 2017
leofeyer
added a commit
that referenced
this pull request
Sep 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements contao/core#7774. It is still work in progress, but it already works for adding images to text elements.