Allow recursive dca picker in the same table #906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 29, 2017
leofeyer
requested changes
Jul 3, 2017
| $menuBuilder = \System::getContainer()->get('contao.menu.picker_menu_builder'); | ||
|
|
||
| if (!$menuBuilder->supportsTable($this->strTable)) | ||
| if (!$menuBuilder->supportsTable($this->strTable) || empty($this->strPickerTable) || empty($this->strPickerField) || empty($this->intPickerId)) |
There was a problem hiding this comment.
We should run those checks before we initialize the menu builder, shouldn't we?
There was a problem hiding this comment.
Agree, changed in 4665cd5
leofeyer
approved these changes
Jul 4, 2017
|
For some reason, this change breaks the link picker (TinyMCE). |
|
It is the |
|
Also, the picker is not applied correctly anymore now:
There should be no yellow background in the news archive view. |
leofeyer
added a commit
that referenced
this pull request
Jul 4, 2017
|
Reverted and fixed in 887bac7 now. |
This was referenced Jul 5, 2017
Closed
leofeyer
added a commit
that referenced
this pull request
Oct 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #883
Unfortunately, there's no cleaner solution…
Also tested to edit a page within the page picker and pick another page for the redirect 💪