Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

eval->encrypt inside Widget class #2603

Closed
aschempp opened this Issue · 3 comments

2 participants

@aschempp
Collaborator

Today I noticed the PersonalData and Registration modules do not support encrypted fields. This is because only DataContainer takes care of encrypting and decrypting values.
However, in my opinion, the encryption should be handled by the widget class. Decrypt "incoming" values and encrypt "outgoing".

I have successfully tested this on custom member fields being encrypted on-the-fly. The en-/decryption has been moved from DataContainer.php to Widget.php (therefor 2 patches)
I also needed to patch the Encryption library to support arrays. The inline documentation already did say "mixed" input, but only string was supported.

I also noticed most of the backend widgets (but none of the frontend widgets) have a custom __set() handling for "value" to deserialize (potential) arrays. To make my patches work, this should be removed. Deserializing is also done in the parent Widget.php class on all values (I don't see a reason why not...).

Download the attachments

--- Originally created on October 8th, 2010, at 11:30am (ID 2603)

@leofeyer leofeyer was assigned
@leofeyer
Owner

There was a little bit more to do, but now it should work fine (see f786f79).

--- Originally created on May 26th, 2011, at 01:55pm

@aschempp
Collaborator

Looks good to me, exactly as in my local patch.

--- Originally created on May 26th, 2011, at 08:24pm

@leofeyer
Owner

--- Originally completed on May 26th, 2011, at 01:55pm

@leofeyer leofeyer closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.