Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getContentElement Hook is now useless #3962

Closed
blairwinans opened this issue Feb 18, 2012 · 2 comments

Comments

@blairwinans
Copy link

commented Feb 18, 2012

I tried translating this issue: #2693, which is where the problem comes from.

You are overwriting the $strBuffer after the Hook runs by calling $objElement->generate(). What, then, is the point of passing $strBuffer at all? Is this intentional?

@blairwinans

This comment has been minimized.

Copy link
Author

commented Feb 18, 2012

Obviously this affects getFrontendModule as well... I can work around the change using the database result, but why even pass and set $strBuffer at all during the Hook if it is getting overwritten?

@leofeyer

This comment has been minimized.

Copy link
Member

commented Feb 23, 2012

Fixed in 8e85c9a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.