Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contao 3 methods: Controller::getTheme() #4662

Closed
aschempp opened this issue Aug 17, 2012 · 10 comments

Comments

Projects
None yet
2 participants
@aschempp
Copy link
Contributor

commented Aug 17, 2012

@contao/workgroup-core

Should be Backend::getTheme() and static. Especially since we have frontend themes too...

@leofeyer

This comment has been minimized.

Copy link
Member

commented Aug 17, 2012

However, $this->getTheme() is used in the front end as well.

@aschempp

This comment has been minimized.

Copy link
Contributor Author

commented Aug 19, 2012

I can only guess why it is used in the frontend, but is that important? The frontend can still call Backend::getTheme()

@leofeyer

This comment has been minimized.

Copy link
Member

commented Aug 21, 2012

The theme is not limited to the back end. It relates to the application, therefore System might be a good place for it?

@aschempp

This comment has been minimized.

Copy link
Contributor Author

commented Aug 21, 2012

How is that, if the theme is defined for each backend user individually?

@leofeyer

This comment has been minimized.

Copy link
Member

commented Aug 21, 2012

There is also a default theme, isn't there? The front end only uses the file mime icons of the theme AFAIK, so maybe we can come up with a better solution?

@aschempp

This comment has been minimized.

Copy link
Contributor Author

commented Aug 22, 2012

Well that's a new topic... In my opinion, Contao should not render mime icons, because they are for the frontend design. So if you need pics, use CSS... Maybe we can drop them, or is it too late?

@leofeyer

This comment has been minimized.

Copy link
Member

commented Aug 29, 2012

We'd have to move the icons to a separate folder then (e.g. assets/mime), so the theme only relates to the back end.

@aschempp

This comment has been minimized.

Copy link
Contributor Author

commented Aug 30, 2012

That would be an option. But what do you think about my suggestion to remove them completely?

@leofeyer

This comment has been minimized.

Copy link
Member

commented Aug 30, 2012

Anything that breaks the backwards compatibility is not interesting right now. Also, I think there should be a default set of mime icons, independent of whether you add them via HTML or CSS.

leofeyer added a commit that referenced this issue Nov 2, 2012

Moved all icons shared in the back end and front end to `assets/conta…
…o/images`, so there are no more interrelations between the front end and the back end theme (see #4662)
@leofeyer

This comment has been minimized.

Copy link
Member

commented Nov 2, 2012

Done in d6d6fca.

@leofeyer leofeyer closed this Nov 2, 2012

leofeyer added a commit that referenced this issue Oct 31, 2014

Moved all icons shared in the back end and front end to `assets/conta…
…o/images`, so there are no more interrelations between the front end and the back end theme (see #4662)

leofeyer added a commit that referenced this issue Oct 31, 2014

Moved all icons shared in the back end and front end to `assets/conta…
…o/images`, so there are no more interrelations between the front end and the back end theme (see #4662)

leofeyer added a commit that referenced this issue Oct 31, 2014

Moved all icons shared in the back end and front end to `assets/conta…
…o/images`, so there are no more interrelations between the front end and the back end theme (see #4662)

leofeyer added a commit that referenced this issue Mar 27, 2015

Moved all icons shared in the back end and front end to `assets/conta…
…o/images`, so there are no more interrelations between the front end and the back end theme (see #4662)

leofeyer added a commit that referenced this issue Jul 23, 2015

Moved all icons shared in the back end and front end to `assets/conta…
…o/images`, so there are no more interrelations between the front end and the back end theme (see #4662)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.