GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub?
to your account
Should be Backend::getTheme() and static. Especially since we have frontend themes too...
However, $this->getTheme() is used in the front end as well.
I can only guess why it is used in the frontend, but is that important? The frontend can still call Backend::getTheme()
The theme is not limited to the back end. It relates to the application, therefore System might be a good place for it?
How is that, if the theme is defined for each backend user individually?
There is also a default theme, isn't there? The front end only uses the file mime icons of the theme AFAIK, so maybe we can come up with a better solution?
Well that's a new topic... In my opinion, Contao should not render mime icons, because they are for the frontend design. So if you need pics, use CSS... Maybe we can drop them, or is it too late?
We'd have to move the icons to a separate folder then (e.g. assets/mime), so the theme only relates to the back end.
That would be an option. But what do you think about my suggestion to remove them completely?
Anything that breaks the backwards compatibility is not interesting right now. Also, I think there should be a default set of mime icons, independent of whether you add them via HTML or CSS.
Moved all icons shared in the back end and front end to `assets/conta…
…o/images`, so there are no more interrelations between the front end and the back end theme (see #4662)
Moved `Controller::getTheme()` to `Backend::getTheme()` (see #4662)
Done in d6d6fca.