Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feed Item addEnclosure doesn't encode spaces in URLs #4839

Closed
brandbrilliance opened this issue Sep 20, 2012 · 1 comment

Comments

@brandbrilliance
Copy link

commented Sep 20, 2012

The function in Feed.php called addEnclosure doesn't encode spaces in URLs.

I've therefore had to hack the core to get this to ensure the URLs don't contain spaces. Many integration scripts like the very popular RSS Graffiti for Facebook RSS auto-posting, cannot handle the spaces, so therefore it doesn't attach the image to the auto-post to FB.

The clients will never stop learning to remove spaces as they think it's ok and it's windows, so there is no making sure they unlearn that behaviour.

            'url' => $this->Environment->base . str_replace(' ', '%20', $strFile),
@leofeyer

This comment has been minimized.

Copy link
Member

commented Sep 22, 2012

Fixed in b2c5642.

@leofeyer leofeyer closed this Sep 22, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.