Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

saving in edit all of tl_page is very slow #6830

Closed
backbone87 opened this issue Mar 27, 2014 · 5 comments
Closed

saving in edit all of tl_page is very slow #6830

backbone87 opened this issue Mar 27, 2014 · 5 comments
Assignees
Labels
Milestone

Comments

@backbone87
Copy link
Contributor

backbone87 commented Mar 27, 2014

ursache:
https://github.com/contao/core/blob/3.5/system/modules/core/dca/tl_page.php#L34
das rekursive generieren der sitemap wird für jede bearbeitete seite im edit all durchgeführt, dadurch wird das speichern extrem langsam, wenn man 100+ seiten bearbeitet.

@leofeyer
Copy link
Member

What do you suggest?

@aschempp
Copy link
Member

How about something like for the style sheets, where the update is done when you return to the list view? I think there's something similar for news too? Maybe for the feed?

@backbone87
Copy link
Contributor Author

there would be multiple solutions:

  1. (good one) add an additional callback for DCT that is executed AFTER the storage process is completly done (it maybe should provide the table and the IDs / fields that were edited)
  2. (good one) generate the sitemap on demand (with transparent caching), so you just delete the sitemap, when a page is being edited, and the next time someone requests the sitemap, its get generated
  3. (not so good one) set a flag somewhere and generate the sitemap in another step

@leofeyer leofeyer modified the milestones: 3.2.10, 3.2.9 Apr 7, 2014
@leofeyer leofeyer modified the milestones: 3.2.11, 3.2.10 May 21, 2014
@leofeyer
Copy link
Member

leofeyer commented Jun 3, 2014

  1. This seems to be a good solution indeed, although we'd have to wait for the next minor version to implement it.
  2. This is difficult, because sitemaps are stored as .xml files and we'd somehow have to redirect the request to PHP, which requires mod_rewrite.
  3. Might not be as good a solution as 1., but does already work for news and calendar feeds. Could maybe be implemented as hotfix.

@leofeyer leofeyer modified the milestones: 3.2.12, 3.2.11 Jun 4, 2014
@leofeyer leofeyer removed this from the 3.2.12 milestone Jun 13, 2014
@leofeyer leofeyer modified the milestones: 3.2.17, 3.2.16 Nov 18, 2014
@leofeyer leofeyer modified the milestones: 3.2.17, 3.2.18 Jan 22, 2015
@leofeyer leofeyer modified the milestones: 3.2.18, 3.2.19 Jan 30, 2015
@leofeyer leofeyer modified the milestones: 3.2.20, 3.2.21 Mar 27, 2015
@leofeyer leofeyer modified the milestones: 3.2.21, 3.5.0 Apr 20, 2015
@leofeyer leofeyer modified the milestones: 3.5.0, 3.5.1 Jun 5, 2015
@leofeyer leofeyer modified the milestones: 3.5.1, 3.x.x Jul 20, 2015
@leofeyer leofeyer modified the milestone: 3.x.x Apr 15, 2016
@leofeyer leofeyer added this to the 3.5.35 milestone Apr 10, 2018
@leofeyer leofeyer modified the milestones: 3.5.35, 3.5.36 Apr 18, 2018
@leofeyer leofeyer modified the milestones: 3.5.36, 4.4.24 Sep 7, 2018
@leofeyer leofeyer self-assigned this Sep 17, 2018
leofeyer added a commit to contao/contao that referenced this issue Sep 17, 2018
@leofeyer
Copy link
Member

Fixed in contao/contao@156f628.

leofeyer added a commit to contao/core-bundle that referenced this issue Sep 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants