Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

Bug in the Installer.php when trying to recognize the collation #7979

Closed
Toflar opened this issue Aug 21, 2015 · 1 comment
Closed

Bug in the Installer.php when trying to recognize the collation #7979

Toflar opened this issue Aug 21, 2015 · 1 comment
Assignees
Labels
Milestone

Comments

@Toflar
Copy link
Member

Toflar commented Aug 21, 2015

When you try to set an explicit collation on a certain field like

'sql' = "varchar(10) COLLATE utf8_general_ci NOT NULL default ''"

It does not work if the collation equals the DB collation settings and it will keep proposing that change in the DB update back end view.
This is due to

if ($field['collation'] != '' && $field['collation'] != \Config::get('dbCollation'))

Obviously I don't need to specify utf8_general_ci if the DB collation is the same but if I want to make sure it is in that collation, then I have to specify it and it should only propose to change it when my DB is NOT utf8_general_ci.

@leofeyer
Copy link
Member

Fixed in 587fcac.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants