Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

3.5.6: versioning no more working …? #8141

Closed
pswerbung opened this issue Dec 1, 2015 · 8 comments
Closed

3.5.6: versioning no more working …? #8141

pswerbung opened this issue Dec 1, 2015 · 8 comments
Assignees
@leofeyer
Labels
defect
Milestone
3.5.7

Comments

@pswerbung
Copy link

I was also in de Contao Demo and in my own installation: in Contao 3.5.6 versioning seems to add the system-log entry but there is no pulldown above the content-element or module anymore. What's wrong?
@pswerbung
Copy link
Author

… after several savings it now seems to work. So we have an issue with the first version(s). They're not correctly catched!

@aschempp
Copy link
Member

aschempp commented Dec 1, 2015

Be aware that a new version is only created if you change something on the record...

@leofeyer
Copy link
Member

leofeyer commented Dec 1, 2015

How do I reproduce this in the online demo?

@pswerbung
Copy link
Author

It's possible when Login as Admin, Access Modules «Applications – Listing», Change the title, hit enter to save. No Version is made. Reedit, Enter … still no version. Then add a Headline (was empty before): version is created ;-)

@leofeyer leofeyer added this to the 3.5.7 milestone Dec 23, 2015
@leofeyer
Copy link
Member

I have debugged the issue. It is caused by the change discussed in #7730:

https://github.com/contao/core/blob/master/system/modules/core/classes/Versions.php#L219

  • If there is a record that has been created a long time ago (like in the Contao demo), the timestamp of its first version is set to the last revision date of the record.
  • When the record is changed, Contao purges this first version, because it is older than the version timeout.
  • Another first version is created, again with the old revision date (!), because the version is created before the record is saved.
  • Next time you save, the version is deleted again and another first version is created; now with an up-to-date revision date.
  • From there on, the versioning works as expected.

@contao/developers Any idea how to fix this?

@leofeyer
Copy link
Member

Except reverting the changes from #7730 of course ;)

@leofeyer
Copy link
Member

Never mind, reverting the changes is correct. Let's instead try to solve the initial problem as described here: #7730 (comment)

leofeyer added a commit that referenced this issue Feb 17, 2016
@leofeyer
Revert the changes from 7686f22 (see #8141).
fa9bbe2
leofeyer added a commit that referenced this issue Feb 17, 2016
@leofeyer
Revert the changes from 7686f22 (see #8141).
bfdfd4f
@leofeyer
Copy link
Member

Fixed in bfdfd4f.

@leofeyer leofeyer self-assigned this Feb 17, 2016
leofeyer added a commit that referenced this issue Mar 1, 2016
@leofeyer
Revert the changes from 7686f22 (see #8141).
5caa9c9
jsonn pushed a commit to jsonn/pkgsrc that referenced this issue Mar 5, 2016
Update contao41 to 4.1.1.
281a294 
### 4.1.1 (2015-03-03)

 * Remove the "disable IP check" field from the back end settings (see #436).
 * Do not quote the search string in `FIND_IN_SET()` (see #424).
 * Always fix the domain and language when generating URLs (see contao/core#8238).
 * Fix two issues with the flexible back end theme (see contao/core#8227).
 * Correctly toggle custom page type icons (see contao/core#8236).
 * Correctly render the links in the monthly/yearly event list menu (see contao/core#8140).
 * Skip the registration related fields if a user is duplicated (see contao/core#8185).
 * Correctly show the form field type help text (see contao/core#8200).
 * Correctly create the initial version of a record (see contao/core#8141).
 * Correctly show the "expand preview" buttons (see contao/core#8146).
 * Correctly check that a password does not match the username (see contao/core#8209).
 * Check if a directory exists before executing `mkdir()` (see contao/core#8150).
 * Do not link to the maintenance module if the user cannot access it (see contao/core#8151).
 * Show the "new folder" button in the template manager (see contao/core#8138).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@leofeyer leofeyer

Labels
defect
Projects
None yet
Milestone
3.5.7
Development

No branches or pull requests
3 participants
@aschempp @leofeyer @pswerbung