Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

Bug: Green arrow for expand node in content preview always visible #8146

Closed
Aybee opened this issue Dec 2, 2015 · 1 comment
Closed

Bug: Green arrow for expand node in content preview always visible #8146

Aybee opened this issue Dec 2, 2015 · 1 comment
Assignees
Labels
Milestone

Comments

@Aybee
Copy link
Contributor

Aybee commented Dec 2, 2015

Hallo Leo,

du hast die Validierung von limit_height h64 aufgesetzt, nachdem die Höhe bereits auf 64px gesetzt wurde. Dadurch wird die Abfrage if (size.height < hgt) niemals wahr werden.

https://github.com/contao/core/blob/master/assets/contao/js/core-uncompressed.js#L1066-L1088

Wahrscheinlich musss div.setStyle('height', hgt); einfach nur nach der Abfrage der Ermittlung der Größe kommen - size = div.getCoordinates();.

In der Online-Demo kannst du das sehen, wenn du in der Content-Listview ein Element betrachtest, welches beispielsweise nur eine Überschrift enthält.

Edit: Vielleicht kann man das auch so machen, dass in dem Fall erst gar kein Image dort rein generiert wird. Ich habe das in meinem Theme so umgesetzt und vermisse dieses ausgegraute Icon, auf welches ich sowieso nicht klicken kann, nicht.

@leofeyer leofeyer added the defect label Dec 2, 2015
@leofeyer leofeyer added this to the 3.5.7 milestone Dec 2, 2015
@leofeyer leofeyer self-assigned this Feb 17, 2016
@leofeyer
Copy link
Member

Fixed in 83a3d82.

jsonn pushed a commit to jsonn/pkgsrc that referenced this issue Mar 5, 2016
### 4.1.1 (2015-03-03)

 * Remove the "disable IP check" field from the back end settings (see #436).
 * Do not quote the search string in `FIND_IN_SET()` (see #424).
 * Always fix the domain and language when generating URLs (see contao/core#8238).
 * Fix two issues with the flexible back end theme (see contao/core#8227).
 * Correctly toggle custom page type icons (see contao/core#8236).
 * Correctly render the links in the monthly/yearly event list menu (see contao/core#8140).
 * Skip the registration related fields if a user is duplicated (see contao/core#8185).
 * Correctly show the form field type help text (see contao/core#8200).
 * Correctly create the initial version of a record (see contao/core#8141).
 * Correctly show the "expand preview" buttons (see contao/core#8146).
 * Correctly check that a password does not match the username (see contao/core#8209).
 * Check if a directory exists before executing `mkdir()` (see contao/core#8150).
 * Do not link to the maintenance module if the user cannot access it (see contao/core#8151).
 * Show the "new folder" button in the template manager (see contao/core#8138).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants