Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

tl_user::dateAdded should have eval->doNotCopy->true #8185

Closed
Toflar opened this issue Jan 13, 2016 · 6 comments
Closed

tl_user::dateAdded should have eval->doNotCopy->true #8185

Toflar opened this issue Jan 13, 2016 · 6 comments
Assignees
@leofeyer
Labels
defect
Milestone
3.5.7

Comments

@Toflar
Copy link
Member

Toflar commented Jan 13, 2016

Same applies for tl_member.
@Aybee
Copy link
Contributor

Aybee commented Jan 14, 2016

👍 Yes, I also recognized that just today after copying a user to a new user.

@leofeyer leofeyer added this to the 3.5.7 milestone Feb 11, 2016
@leofeyer
Copy link
Member

I have found a couple of other fields which should not be copied either IMHO:

  • tl_member.dateAdded
  • tl_member.lastLogin
  • tl_member.currentLogin
  • tl_member.loginCount
  • tl_member.locked
  • tl_member.session
  • tl_member.createdOn
  • tl_user.dateAdded
  • tl_user.lastLogin
  • tl_user.currentLogin
  • tl_user.loginCount
  • tl_user.locked
  • tl_user.session

@contao/developers Any objections against adding the "do not copy" flag to all of them?

@Toflar
Copy link
Member Author

Toflar commented Feb 15, 2016

I agree. So, no 😄

@aschempp
Copy link
Member

Agreed, but will they be initialized with the DCA default value? E.g. for loginCount?

@leofeyer
Copy link
Member

Yes, they will.

leofeyer added a commit that referenced this issue Feb 18, 2016
@leofeyer
Do not copy the registration related fields if a user is duplicated (…
1ee2863 
…see #8185).
@leofeyer leofeyer self-assigned this Feb 18, 2016
@leofeyer
Copy link
Member

Fixed in 1ee2863.

leofeyer added a commit that referenced this issue Mar 1, 2016
@leofeyer
Do not copy the registration related fields if a user is duplicated (…
c2eded6 
…see #8185).
jsonn pushed a commit to jsonn/pkgsrc that referenced this issue Mar 5, 2016
Update contao41 to 4.1.1.
281a294 
### 4.1.1 (2015-03-03)

 * Remove the "disable IP check" field from the back end settings (see #436).
 * Do not quote the search string in `FIND_IN_SET()` (see #424).
 * Always fix the domain and language when generating URLs (see contao/core#8238).
 * Fix two issues with the flexible back end theme (see contao/core#8227).
 * Correctly toggle custom page type icons (see contao/core#8236).
 * Correctly render the links in the monthly/yearly event list menu (see contao/core#8140).
 * Skip the registration related fields if a user is duplicated (see contao/core#8185).
 * Correctly show the form field type help text (see contao/core#8200).
 * Correctly create the initial version of a record (see contao/core#8141).
 * Correctly show the "expand preview" buttons (see contao/core#8146).
 * Correctly check that a password does not match the username (see contao/core#8209).
 * Check if a directory exists before executing `mkdir()` (see contao/core#8150).
 * Do not link to the maintenance module if the user cannot access it (see contao/core#8151).
 * Show the "new folder" button in the template manager (see contao/core#8138).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@leofeyer leofeyer

Labels
defect
Projects
None yet
Milestone
3.5.7
Development

No branches or pull requests
4 participants
@Toflar @aschempp @Aybee @leofeyer