Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

Piwik Template anpassen: analytics_piwik.html5 #8229

Closed
fenepedia opened this issue Feb 18, 2016 · 3 comments
Closed

Piwik Template anpassen: analytics_piwik.html5 #8229

fenepedia opened this issue Feb 18, 2016 · 3 comments
Assignees
Labels
Milestone

Comments

@fenepedia
Copy link

Hab gerade gesehen, dass sich der Trackingcode für Piwik minimal geändert hat.

alt:

    var g = document.createElement('script'); g.src = u + 'piwik.js'; g.async = true;
    var s = document.getElementsByTagName('script')[0]; s.parentNode.insertBefore(g, s);
  })();
</script>

neu:

    var d=document, g=d.createElement('script'), s=d.getElementsByTagName('script')[0];
    g.type='text/javascript'; g.async=true; g.defer=true; g.src=u+'piwik.js'; s.parentNode.insertBefore(g,s);
  })();
</script>
@leofeyer
Copy link
Member

Inhaltlich ist nur das defer-Attribut dazu gekommen. Da wir sowieso nur HTML5 ausgeben, habe ich das type="text/javascript"-Attribut entfernt. Neu wäre also:

var d=document, g=d.createElement('script'), s=d.getElementsByTagName('script')[0];
g.async=true; g.defer=true; g.src=u+'piwik.js'; s.parentNode.insertBefore(g,s);

@leofeyer leofeyer added this to the 4.2.0 milestone Feb 18, 2016
@fenepedia
Copy link
Author

danke

leofeyer added a commit to contao/core-bundle that referenced this issue Apr 8, 2016
@leofeyer leofeyer self-assigned this Apr 8, 2016
@leofeyer
Copy link
Member

leofeyer commented Apr 8, 2016

Geändert in contao/core-bundle@ded8b0f.

@leofeyer leofeyer closed this as completed Apr 8, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants