Closed legend cause problem with form validation

[netzarbeiter]

If a legend with mandatory fields is closed by default there is a problem with form validation.

Legend closed:

Legend opened:

[leofeyer]

Legends should always be open if they contain mandatory fields. Can the issue be reproduced in the online demo?

[aschempp]

Well you can manually close them…

[netzarbeiter]

You can reproduce it in the online demo.

• Add a new content element «Hyperlink»
• Close «Hyperlink settings»
• Save

[leofeyer]

Well you can manually close them…

See https://youtu.be/aqAuuSo_p8M?t=90

[aschempp]

That only works after reload, which does not happen with browser validation…

[fritzmg]

Sections with mandatory fields should be opened again via JavaScript before the form is submitted.

[leofeyer]

@aschempp Don't know if you have listened, but the video clearly says:

… also recognizes mandatory fields and makes sure that they are never inside a collapsed section.

[fritzmg]

@leofeyer the problem occurs when the user collapses a section manually (see netzarbeiter's reproduction steps). The video only states, that sections are always uncollapsed if there are mandatory fields in them when a record is opened. This works as expected. However, this is not what this issue is about.

[leofeyer]

@fritzmg The initial description is:

If a legend with mandatory fields is closed by default

So I don't think it is about manual collapsing. But it actually does not matter, because Contao should never collapse a section containing mandatory fields – no matter if the section was closed by default or manually.

[fritzmg]

But it actually does not matter, because Contao should never collapse a section containing mandatory fields – no matter if the section was closed by default or manually.

I don't agree with that. I often collapse sections, regardless of whether they contain mandatory fields or not, while I create or edit a record which has a lot of sections, to get a better overview. Imho it would be detrimental to the user experience if you suddenly disallow the collapse of sections containing mandatory fields.

[Toflar]

Yeah, I think opening them before the form is submitted, makes more sense.

[leofeyer]

I often collapse sections, regardless of whether they contain mandatory fields or not

Yes, but only if those fields contain a value. Otherwise collapsing does not make any sense at all, because not filling in the fields will lead to an error message upon submit.

Therefore Contao will always open sections if there are empty mandatory fields.

[fritzmg]

Yes, but only if those fields contain a value. Otherwise collapsing does not make any sense at all, because not filling in the fields will lead to an error message upon submit.

No, I meant I collapse all fields and open them one by one while creating/editing a record. Just because I collapse a section does not necessarily mean I do not intend to enter any values in the contained fields while editing/creating a record.

Therefore Contao will always open sections if there are empty mandatory fields.

Do you mean when loading an entry? Yes, that currently works as expected and does not need to be changed. I was concerned you want to remove the functionality to be able to collapse sections containing mandatory fields altogether.

The issue here only arises if you manually collapse a section containing a mandatory field and then click any of the [type="submit"] buttons. Thus the solution would be to simply do something like this (jQuery version):

$('.tl_submit_container [type="submit"]').click(function(){
    $(this).parents('form').find('fieldset').each(function(){
        if($(this).find('[required]').length > 0){
            // un-collapse this fieldset
        }
    });
});

[leofeyer]

Fixed in 36fbc41.