This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
The hook isVisibleElement is not called when shown hidden elements is activated in fe preview #8312
Comments
|
Fixed in ec9cd0c. |
leofeyer
added a commit
that referenced
this issue
Apr 21, 2016
jsonn
pushed a commit
to jsonn/pkgsrc
that referenced
this issue
Apr 23, 2016
### 4.1.3 (2016-04-22) * Use data URIs for the image preview in the back end. * Use DIRECTORY_SEPARATOR to convert kernel.cache_dir into a relative path (see #464). * Always trigger the "isVisibleElement" hook (see contao/core#8312). * Do not change all sessions when switching users (see contao/core#8158). * Do not allow to close fieldsets with empty required fields (see contao/core#8300). * Make the path related properties of the File class binary-safe (see contao/core#8295). * Correctly validate and decode IDNA e-mail addresses (see contao/core#8306). * Skip forward pages entirely in the book navigation module (see contao/core#5074). * Do not add the X-Priority header in the Email class (see contao/core#8298). * Determine the search index checksum in a more reliable way (see contao/core#7652).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The early return statement causes the hook not to be called when "show hidden elements" is activated. For Contao elements, this might be fine because you want them to be shown when that option is true. However, that hook is for developers and - by definition - should allow developers to say "hey, my element is still not visible, no matter what you said in the FE preview". I think this can be considered a bug even though people are maybe relying on the fact that the hook is not called when the option is activated. Moreover, I cannot come up with any use case for that matter anyway.
The text was updated successfully, but these errors were encountered: