Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

Akkordeon | role=tablist etc. is wrong (Bug in Contao 3.5.x and Contao 4.x) #8344

Closed
MacKP opened this issue May 22, 2016 · 4 comments
Closed
Assignees
Labels
Milestone

Comments

@MacKP
Copy link

MacKP commented May 22, 2016

As mentioned at the conference from Sonja Weckenmann and @mayerhh the role

tablist

and

multiselectable="true"

is wrong here.

Here is an Link to the slide -> https://pbs.twimg.com/media/Ci4wk7IVAAAgw1a.jpg:large

I can try to make an PR for that when we strike an agreement what it should look like.

regards

@MacKP
Copy link
Author

MacKP commented May 22, 2016

Here is an old Ticket with aria-expended (just for mention it) -> #7620

@MacKP
Copy link
Author

MacKP commented May 23, 2016

Some more Information about this -> http://w3c.github.io/aria/practices/aria-practices.html#accordion

@leofeyer leofeyer added this to the 3.5.13 milestone May 23, 2016
@leofeyer
Copy link
Member

leofeyer commented Jun 9, 2016

It is not a problem to remove the tablist role in the MooTools accordion, but jQuery adds it by default (see https://github.com/jquery/jquery-ui/blob/master/ui/widgets/accordion.js#L84), so we will have to create a pull request there.

And I cannot find a multiselectable attribute anywhere. Where is this added?

@leofeyer
Copy link
Member

leofeyer commented Jun 9, 2016

Fixed in 8fa62fc.

Since we are not using an accordion container, the tablist attribute is not added via jQuery. We might still create a pull request there to get it fixed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants