Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

Page Setting: Redirect Type 301 - SEO error if no redirect page selected (breadcrumb) #8377

Closed
eBlick opened this issue Jun 21, 2016 · 7 comments
Assignees
Labels
Milestone

Comments

@eBlick
Copy link

eBlick commented Jun 21, 2016

Internal redirect pages need to have a target in the page settings. Otherwise the link in the breadcrumb navigation will be the origin internal page and the redirection triggers after clicking the link.
This causes errors in SEO Site Checks where internal links should not target to a 301-URL.

To select the target upfront seems not to be appropriate because forwarding to the next regular subpage is a common feature.

The links from a forwarded page in the breadcrumb should contain the next regular subpage if no target is selected.

@leofeyer
Copy link
Member

What exactly is the problem?

@fritzmg
Copy link
Contributor

fritzmg commented Jun 21, 2016

"SEO" wise, this doesn't actually matter, probably.

However, those check tools simply complain, that a link on a page that leads to another page within the same domain, actually response with a 301 redirect pointing to a page, that is also within the same domain. It would be more efficient to link to the redirected page directly.

So imagine a link of a Contao navigation module that says

<a href="foo.html">Foo</a>

where in this case, foo is a internal redirect page. When you open http://example.org/foo.html the webserver (Contao) responds with a 301 status code and redirects you to, say moo.html. This is a slight inefficiency, because the link could have pointed to

<a href="moo.html"></a>

right away, saving one redirect for the client.

@leofeyer
Copy link
Member

the link could have pointed to <a href="moo.html">…</a> right away, saving one redirect for the client.

But that's exactly like the navigation menu works already.

@eBlick
Copy link
Author

eBlick commented Jun 22, 2016

Only if a redirect page is selected in the page settings.
If not, it is pointed to „foo“ first and will be forwarded via 301 to „moo“ afterwards.

Am 22.06.2016 um 09:40 schrieb Leo Feyer notifications@github.com:

the link could have pointed to right away, saving one redirect for the client.

But that's exactly like the navigation menu works already.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub #8377 (comment), or mute the thread https://github.com/notifications/unsubscribe/AGVWgfX-5H8ytaSJHPSn-8G5O9iySefhks5qOObkgaJpZM4I6vvZ.

@fritzmg
Copy link
Contributor

fritzmg commented Jun 22, 2016

But that's exactly like the navigation menu works already.

Oh, right. Then I don't undestand what @eBlick means.

@Aybee
Copy link
Contributor

Aybee commented Jun 22, 2016

Go to Demo. Set page Modules (modules.html) to Internal redirect. Do not choose a Redirect page. See breadcrumb in FE. Page Modules links to modules.html but gets redirected to navigation.html.

BTW there is an error with ModuleBooknav which gets included on page navigation.html

Fatal error: Call to a member function getFrontendUrl() on null in /home/www/system/modules/core/modules/ModuleBooknav.php on line 137

So you have to inactivate this CE first if you want to test.

@leofeyer leofeyer added this to the 3.5.15 milestone Jun 22, 2016
@leofeyer leofeyer modified the milestones: 3.5.15, 3.5.16 Jul 15, 2016
@leofeyer leofeyer self-assigned this Aug 25, 2016
@leofeyer
Copy link
Member

leofeyer commented Aug 25, 2016

Fixed in 09e8dba.

jsonn pushed a commit to jsonn/pkgsrc that referenced this issue Sep 8, 2016
### 4.2.3 (2016-09-06)

 * Do not double URL encode the content syndication links.
 * Use CSS3 transforms instead of transitions to animate the off-canvas navigation.
 * Improve the exception handling when using the resource locator (see #557).
 * Correctly reset the filter menu in parent view.
 * Support all characters but =!<> and whitespace in simple tokens (see contao/core#8436).
 * Check the user's permission when generating links in the picker (see contao/core#8407).
 * Handle forward pages without target in the navigation modules (see contao/core#8377).
 * Provide the same template variables for downloads and enclosures (see contao/core#8392).
 * Handle %n when parsing date formats (see contao/core#8411).
 * Fix the module wizard's accessibility (see contao/core#8391).
 * Correctly initialize TinyMCE in sub-palettes in Firefox (see contao/core#3673).
 * Validate form field names more accurately (see contao/core#8403).
 * Correctly show the ctime, mtime and atime of a folder (see contao/core#8408).
 * Correctly index changed pages (see contao/core#8439).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants