Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

rename folder in Contao backend causes warning #8674

Closed
fiedsch opened this issue Mar 22, 2017 · 1 comment
Closed

rename folder in Contao backend causes warning #8674

fiedsch opened this issue Mar 22, 2017 · 1 comment
Assignees
@leofeyer
Labels
defect
Milestone
3.5.26

Comments

@fiedsch
Copy link

fiedsch commented Mar 22, 2017

A missing preg_quote($strSource, '@') in Dbafs::moveResource()
https://github.com/contao/core/blob/master/system/modules/core/library/Contao/Dbafs.php#L261
causes a warning like

Warning: preg_replace(): Unknown modifier 'f' in system/modules/core/library/Contao/Dbafs.php on line 261

when a folder with an @ in its name is copied.

How to recreate: (can't recreate in the online demo due to missing access rights in the file manager)

  • Create a folder some@foo
  • Click the + icon to copy the folder
  • Click 'insert' to produce the warning (showing "Ein Fehler ist aufgetreten!" in the backend)

Applies to Contao 3 and Contao 4
@fiedsch fiedsch changed the title rename folder in Contao backend throws error rename folder in Contao backend causes warning Mar 22, 2017
@leofeyer leofeyer added this to the 3.5.26 milestone Mar 23, 2017
@leofeyer leofeyer self-assigned this Apr 18, 2017
leofeyer added a commit that referenced this issue Apr 18, 2017
@leofeyer
Correctly move folders with an "@" in their name (see #8674).
5fa4427
@leofeyer
Copy link
Member

Fixed in 5fa4427.

leofeyer added a commit that referenced this issue Apr 20, 2017
@leofeyer
Correctly move folders with an "@" in their name (see #8674).
814673c
jsonn pushed a commit to jsonn/pkgsrc that referenced this issue Apr 25, 2017
Update contao43 to 4.3.9.
8a9754a 
# Contao calendar bundle change log

### 4.3.8 (2017-04-24)

 * Correctly use the en dash in the calendar modules (see contao/core#8690).
 * Correctly support 64 character template names everywhere (see contao/core#6819).

# Contao comments bundle change log

### 4.3.8 (2017-04-24)

 * Correctly support 64 character template names everywhere (see contao/core#6819).

# Contao core bundle change log

### 4.3.9 (2017-04-25)

 * Revert the Punycode library changes (see contao/core#8693).

### 4.3.8 (2017-04-24)

 * Inline small images in protected folders in the file manager (see #636).
 * Correctly encode the URL in the DataContainer::switchToEdit() method (see #762).
 * Fix the parent view drag and drop in Firefox (see #666).
 * Correctly display the search results in the extended tree view (see #739).
 * Update the Punycode library to version 2 (see #748).
 * Fix the "delete file" button for non-admin users (see #764).
 * Prevent endless loops in the book navigation module (see contao/core#8665).
 * Limit the maximum size of dimensionless SVGs in the back end (see contao/core#8684).
 * Correctly support 64 character template names everywhere (see contao/core#6819).
 * Remove the UTF-8 BOM when combining files (see contao/core#8689).
 * Correctly move folders with an "@" in their name (see contao/core#8674).
 * Correctly redirect to the last page visited upon login (see contao/core#8632).

### 4.3.7 (2017-03-23)

 * Check the database connection in the WebsiteRootsConfigProvider class.
 * Fix the %2B conversion in the Controller::addToUrl() method.

# Contao listing bundle change log

### 4.3.8 (2017-04-24)

 * Correctly support 64 character template names everywhere (see contao/core#6819).

# Contao news bundle change log

### 4.3.8 (2017-04-24)

 * Correctly support 64 character template names everywhere (see contao/core#6819).

# Contao newsletter bundle change log

### 4.3.8 (2017-04-24)

 * Correctly support 64 character template names everywhere (see contao/core#6819).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@leofeyer leofeyer

Labels
defect
Projects
None yet
Milestone
3.5.26
Development

No branches or pull requests
2 participants
@leofeyer @fiedsch