This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
Detailed Browserversions #3826
Merged
Detailed Browserversions #3826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The versions property contains the complete numeric version of a browser splittet into an array.
|
I'd prefer to add |
|
Its also ok, i used the array to not modify too much and to have access to the complete version number. The chrome for example have a version number with 4 parts. |
leofeyer
added a commit
that referenced
this pull request
Jan 19, 2012
leofeyer
added a commit
that referenced
this pull request
Jan 19, 2012
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a versions property contains the complete numeric version of a browser splittet into an array. I need this because I have to check an explizit browser version (in my case only major and minor, but maybe i need more).
Please dont ask me, why git says \ No newline at end of file for the system/config/agents.php file, i don't change the last line and as far as i can see with a hex editor, there is no difference from my file to your file in the last line. But for the system/libraries/Environment.php there is no last line ending conflict ... i'm a bit confused about this O.o
Maybe there is a single CR (without NL), that i don't see in my version. Please have a look with a hex editor into your version of the agents.php file, for a single CR in the last line. I have this problem with another project and I was only able to see the single CR with a hex editor.