Fix empty css definition, #3830 #3840

Closed
wants to merge 283 commits into
from

Conversation

Projects
None yet
@ideadapt

a selector with no properties was not handled correctly. the opening { was removed.
removed substr method call because it caused the bug. its purpose was unknown.

EDIT: looks like i pushed to the wrong branch. should have been 2.11.x. there is another pull request for the same bug at #3847

leofeyer added some commits Oct 17, 2011

@aschempp

This comment has been minimized.

Show comment
Hide comment
@aschempp

aschempp Jan 12, 2012

Member

Are you sure this is the desired effect? If there is a hook but it does not return a database object, the following "if-else" is never run.

Are you sure this is the desired effect? If there is a hook but it does not return a database object, the following "if-else" is never run.

@leofeyer

This comment has been minimized.

Show comment
Hide comment
@leofeyer

leofeyer Jan 12, 2012

Member

@aschempp You are right, of course. Fixed in db1af3d.

Member

leofeyer commented on 03cd541 Jan 12, 2012

@aschempp You are right, of course. Fixed in db1af3d.

@xchs

This comment has been minimized.

Show comment
Hide comment
@xchs

xchs Jan 16, 2012

Contributor

In der .htaccess.default wäre noch das Copyright upzudaten: L3 und L22

Contributor

xchs commented on 0bff6a6 Jan 16, 2012

In der .htaccess.default wäre noch das Copyright upzudaten: L3 und L22

@xchs

This comment has been minimized.

Show comment
Hide comment
@xchs

xchs Jan 18, 2012

Contributor

This commit doesn't work for me. There are now problems with file paths, e.g. if I want to run the Contao install tool I get:

<title>Contao-Installtool - Contao Open Source CMS 2.11</title>
<base href="http://git.musicacademy.local/">
<link rel="stylesheet" href="TL_SCRIPT_URLplugins/stylect/css/stylect.css" media="all">
<link rel="stylesheet" href="TL_SCRIPT_URLsystem/themes/default/basic.css" media="all">
<link rel="stylesheet" href="TL_SCRIPT_URLsystem/themes/default/install.css" media="all">
<!--[if IE]><link rel="stylesheet" href="TL_SCRIPT_URLsystem/themes/default/iefixes.css"><![endif]-->
<script>var CONTAO_THEME="default",CONTAO_COLLAPSE="Bereich schließen",CONTAO_EXPAND="Bereich öffnen",CONTAO_LOADING="Die Daten werden geladen",CONTAO_SCRIPT_URL="TL_SCRIPT_URL",REQUEST_TOKEN="520757881bb20bcd2fb70ac1b9ac00f9";</script>
<script src="TL_PLUGINS_URLplugins/mootools/1.4.2/mootools-core.js"></script>
<script src="TL_PLUGINS_URLplugins/mootools/1.4.2/mootools-more.js"></script>

<script src="TL_SCRIPT_URLplugins/stylect/js/stylect.js"></script>
<script src="TL_SCRIPT_URLcontao/contao.js"></script>
<script src="TL_SCRIPT_URLsystem/themes/default/hover.js"></script>
<!--[if lt IE 9]><script src="TL_PLUGINS_URLplugins/html5shim/html5-3.js"></script><![endif]-->
Contributor

xchs commented on 6133eb4 Jan 18, 2012

This commit doesn't work for me. There are now problems with file paths, e.g. if I want to run the Contao install tool I get:

<title>Contao-Installtool - Contao Open Source CMS 2.11</title>
<base href="http://git.musicacademy.local/">
<link rel="stylesheet" href="TL_SCRIPT_URLplugins/stylect/css/stylect.css" media="all">
<link rel="stylesheet" href="TL_SCRIPT_URLsystem/themes/default/basic.css" media="all">
<link rel="stylesheet" href="TL_SCRIPT_URLsystem/themes/default/install.css" media="all">
<!--[if IE]><link rel="stylesheet" href="TL_SCRIPT_URLsystem/themes/default/iefixes.css"><![endif]-->
<script>var CONTAO_THEME="default",CONTAO_COLLAPSE="Bereich schließen",CONTAO_EXPAND="Bereich öffnen",CONTAO_LOADING="Die Daten werden geladen",CONTAO_SCRIPT_URL="TL_SCRIPT_URL",REQUEST_TOKEN="520757881bb20bcd2fb70ac1b9ac00f9";</script>
<script src="TL_PLUGINS_URLplugins/mootools/1.4.2/mootools-core.js"></script>
<script src="TL_PLUGINS_URLplugins/mootools/1.4.2/mootools-more.js"></script>

<script src="TL_SCRIPT_URLplugins/stylect/js/stylect.js"></script>
<script src="TL_SCRIPT_URLcontao/contao.js"></script>
<script src="TL_SCRIPT_URLsystem/themes/default/hover.js"></script>
<!--[if lt IE 9]><script src="TL_PLUGINS_URLplugins/html5shim/html5-3.js"></script><![endif]-->

This comment has been minimized.

Show comment
Hide comment
Member

leofeyer replied Jan 18, 2012

See #3827

@leofeyer leofeyer closed this Jan 25, 2012

@leofeyer

This comment has been minimized.

Show comment
Hide comment
@leofeyer

leofeyer Jan 25, 2012

Member

its purpose was unknown

Just because you don't understand the purpose, it does not mean that there is none!

Member

leofeyer commented Jan 25, 2012

its purpose was unknown

Just because you don't understand the purpose, it does not mean that there is none!

@NinaG

This comment has been minimized.

Show comment
Hide comment
@NinaG

NinaG Feb 10, 2012

Es ist manchmal einfach nur beruhigend, wenn man auf ein Problem hinweisen will ... und dann merkt, dass du es schon längst gelöst hast und man nur noch bis zum Update warten muss. Danke :)

NinaG commented on f875963 Feb 10, 2012

Es ist manchmal einfach nur beruhigend, wenn man auf ein Problem hinweisen will ... und dann merkt, dass du es schon längst gelöst hast und man nur noch bis zum Update warten muss. Danke :)

@xchs

This comment has been minimized.

Show comment
Hide comment
@xchs

xchs May 16, 2012

Contributor

Since Contao 3 uses now namespaces we should mention here PHP 5.3 as a prerequisite.

Contributor

xchs commented on INSTALL.txt in 2add961 May 16, 2012

Since Contao 3 uses now namespaces we should mention here PHP 5.3 as a prerequisite.

This comment has been minimized.

Show comment
Hide comment
@leofeyer

leofeyer May 21, 2012

Member

Will be changed in the next commit.

Member

leofeyer replied May 21, 2012

Will be changed in the next commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment