Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Added some missing title attributes for various JavaScript pickers #4222

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
3 participants
Contributor

xchs commented Apr 20, 2012

This is my implementation of ticket #2634.

Added also some missing language variables that were not shown in the simple modal window title and fixed a few other minor issues.

BTW: If the new language variables for the title attributes doesn't fit well, feel free to replace them by something else.

I think you should use specialchars() while inside HTML attributes.

Owner

xchs replied May 22, 2012

Regarding this commit and 8106739:

What about my modifications in these files:

Did they not fit?

I added there some missing language variables that were not shown in the simple modal window title (like mentioned by @lionel-m in #4347, too). As you can see, due to the lack of a corresponding language variable there is shown a "Untitled" title in the simple modal header.

Back end modules

Allowed page types

Owner

leofeyer commented Apr 20, 2012

It is not necessary and not always correct to assign an alt attribute to every image. Also, if there is an alt attribute, there is no need to additionally set a title attribute (probably even with the same content).

Owner

leofeyer commented May 22, 2012

I have implemented the appropriate changes in 8106739.

@leofeyer leofeyer closed this May 22, 2012

@leofeyer leofeyer added a commit that referenced this pull request Sep 5, 2016

@leofeyer leofeyer Help wizard and title fixed from #4222 and #4347 163c803
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment