This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
frontend preview for news articles #7504
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -288,7 +288,7 @@ protected function getMetaFields($objArticle) | |||
| * @param boolean | |||
| * @return string | |||
| */ | |||
| protected function generateNewsUrl($objItem, $blnAddArchive=false) | |||
| public function generateNewsUrl($objItem, $blnAddArchive=false) | |||
There was a problem hiding this comment.
This should be public static function otherwise it will trigger a "non-static function cannot be called statically" error.
|
That would be cool for events as well but the code cannot work, as the |
|
+1 |
leofeyer
added a commit
to contao/news-bundle
that referenced
this pull request
Oct 26, 2015
leofeyer
added a commit
to contao/calendar-bundle
that referenced
this pull request
Oct 26, 2015
|
Implemented in contao/core-bundle@43797a4, contao/calendar-bundle@5b4f705 and contao/news-bundle@6e83434. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just a little feature to use the frontend preview on news articles