remove $(document).ready()

[marcobiedermann]

All functions are called at the bottom of the page, which means the document is already ready.

[leofeyer]

This may be right, but since we don't know, why not leave the function call there? Does it noticeably affect the performance?

[marcobiedermann]

It does not affect the performance that much, just a bit.
I think this is irrelevant and so less code is cleaner code. It will work perfectly fine without the extra function call.

[marcobiedermann]

So to get the best perceived load time, put your script at the bottom of the page. […] And if you're going to do that, then there's no need to use ready, though of course you could if you liked.

http://stackoverflow.com/questions/6026645/document-readyfunction-vs-script-at-the-bottom-of-page

[leofeyer]

I know. But can we be sure that the scripts are always at the bottom of the page? What if someone adds a module via insert tag?

[Aybee]

What if something is included with $GLOBALS['TL_BODY'][]?
I like this domready wrapper as it also is a reminding marker for that the script needs the DOM to be loaded first.

[leofeyer]

@contao/developers /cc

[Toflar]

We can safely remove them. That's my opinion :)

[aschempp]

I would not remove them. Also because they're a safe wrapper for variables and jquery (like so:)

jQuery(document).ready(function($) {
   // all variables wrapped in function and $ is jQuery
});

[aschempp]

Which means I would remove the outer function ;-)

[leofeyer]

But the outer function is shorter, so in terms of page size optimization, it would make more sense to remove the inner one :)

[ausi]

IMO we should still listen to domready, because someone could rely on the current behaviour. But there is a shorter version:

Before:

(function($) {
    $(document).ready(function() {
        // code…
    });
})(jQuery);

After:

jQuery(function($) {
    // code…
});

[backbone87]

i think ausi's variant is the way to go. keeps the global clean and you get a save jQuery reference and are safe, if your script isnt at the end of the body.

[leofeyer]

Is there a shorter version for MooTools as well?

// Current wrapper
(function($) {
    window.addEvent('domready', function() {
        // …
    });
})(document.id);

[aschempp]

Well you don't need the outer wrapper if you simply use document.id instead of $ in your code

[leofeyer]

I know. But that is actually not the answer to the question :)

[backbone87]

window.addEvent("domready", function() {
  var $ = document.id;
});

[leofeyer]

Changed in contao/core-bundle@ef20adf.